Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Brotli encoding #15

Merged
merged 2 commits into from
Jan 20, 2019
Merged

Add support for Brotli encoding #15

merged 2 commits into from
Jan 20, 2019

Conversation

kevva
Copy link
Contributor

@kevva kevva commented Jan 19, 2019

Since support for Brotli was added to core in 11.7.0, I think this should be added again, this time without a native dependency :).

Fixes #12.

silverwind
silverwind approved these changes Jan 19, 2019
View reviewed changes
Copy link

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a word about brotli support to README, otherwise LGTM.

@kevva
Copy link
Contributor Author

kevva commented Jan 19, 2019

Should we lock xo or drop support for Node.js 4 @sindresorhus? I'm thinking that you maybe want to do that in a separate commit.

@sindresorhus sindresorhus merged commit 9748dd9 into master Jan 20, 2019
@sindresorhus
Copy link
Owner

Thanks Kevin. I'll fix the XO stuff after merge.

@sindresorhus sindresorhus deleted the brotli branch January 20, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevva @sindresorhus @silverwind