Remove content-encoding header

[binary-person]

this should fix #28

[sindresorhus]

You need to update the types too.

[binary-person]

that would be a breaking change as one would need to export the UncompressedIncomingMessage type as well for the user and index.test-d.ts, so code that used to be

const decompressResponse = require('decompress-response');

would need to be rewritten as

const decompressResponse = require('decompress-response').decompressResponse;

is it alright for that to happen?

[sindresorhus]

You can still use a module.exports. You just put the type in a namespace: https://github.com/sindresorhus/typescript-definition-style-guide#documentation

[binary-person]

alright, thanks! I'm still pretty new to typescript, and wasn't familiar with the idea of namespaces. can you check the commit out?

[sindresorhus]

Would be better to use the Omit type.

[binary-person]

I've tried before with Omit but since node's http.d.ts's IncomingHttpHeaders extends NodeJS.Dict<string | string[]>, the resulting type when used with Omit is [x: string]: string | string[]; [x: number]: string | string[];

[sindresorhus]

Does it work better with https://github.com/sindresorhus/type-fest/blob/main/source/except.d.ts (stricter version of Omit) (just copy-paste it in)? If not, what you have is fine.

[binary-person]

no, it doesn't work. it yields the same problem with Omit, with the resulting type being [x: string]: string | string[]; [x: number]: string | string[];