Transition to Typescript #112
Conversation
| @@ -14,8 +14,8 @@ jobs: | |||
| - 18 | |||
| - 16 | |||
There was a problem hiding this comment.
Should support of node 16 be dropped?
| @@ -1,12 +1,14 @@ | |||
| { | |||
| "extends": "@sindresorhus/tsconfig", | |||
| "compilerOptions": { | |||
| "lib": [ | |||
| "es2021" | |||
There was a problem hiding this comment.
Could be es2023 if support of node 16 is dropped
| "types": "./dist/index.d.ts", | ||
| "default": "./dist/index.js" | ||
| }, | ||
| "sideEffects": false, | ||
| "engines": { | ||
| "node": ">=16" |
There was a problem hiding this comment.
Should support of node 16 be dropped?
| function getPathSegments(path: string) { | ||
| const parts = []; | ||
| let currentSegment = ''; | ||
| let currentPart = 'start'; |
There was a problem hiding this comment.
Idea: use Symbols in place of string constants
| */ | ||
| export function getProperty<ObjectType, PathType extends string, DefaultValue = undefined, ReturnType = ObjectType extends AnObject | AFunction ? (unknown extends Get<ObjectType, PathType> ? DefaultValue : Get<ObjectType, PathType>) : undefined>( | ||
| object: ObjectType, | ||
| path?: PathType, |
There was a problem hiding this comment.
Fix: original typescript definition had path as manadatory parameter
| } | ||
| } | ||
|
|
||
| return (object === undefined ? defaultValue : object) as ReturnType; |
There was a problem hiding this comment.
Generic type ReturnType may need more work. Currently compatible with original typescript definition but not always accurate.
|
While I appreciate the pull request, it's generally better to open an issue before doing large changes like this. I'm not really interested in moving to TypeScript. It adds a lot of development overhead without much gain. You gain most with TypeScript from codebases that are constantly changing, but this package is pretty much done. |
Hi,
I am experimenting with this package and felt like contributing a little. Here's a first draft at switching to Typescript.
Regards,