Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop earlier if dom was already ready #48

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Stop earlier if dom was already ready #48

merged 4 commits into from
Sep 6, 2024

Conversation

fregante
Copy link
Collaborator

@fregante fregante commented Aug 20, 2024 •
edited
Loading

Related to #46

@fregante fregante marked this pull request as ready for review September 5, 2024 17:29
@fregante fregante changed the title Stop if dom was already ready Stop earlier if dom was already ready Sep 5, 2024
@fregante
Copy link
Collaborator Author

fregante commented Sep 5, 2024

I forgot that the issue was specific to observeReadyElements and not elementReady. I added some tests to the latter, but the additional code isn't strictly necessary.

Feel free to discard the changes to index.js and just merge test.js

@sindresorhus sindresorhus merged commit 5e2474e into main Sep 6, 2024
2 checks passed
@sindresorhus sindresorhus deleted the dom-already branch September 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fregante @sindresorhus