Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle args in Emittery.mixin constructor #101

Closed
wants to merge 3 commits into from
Closed

Handle args in Emittery.mixin constructor #101

wants to merge 3 commits into from

Conversation

tomfuertes
Copy link

@tomfuertes tomfuertes commented Aug 6, 2022 •
edited
Loading

Refs #79

@sindresorhus
Copy link
Owner

Can you add a type test?

sindresorhus
sindresorhus reviewed Aug 6, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@tomfuertes @sindresorhus
Update index.d.ts
c67a43e 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@tomfuertes
Copy link
Author

tomfuertes commented Aug 6, 2022 •
edited
Loading

Can you add a type test?

I googled for a bit and it's well outside my current typescript skillset. I'll 👀 for changes and hope to pay it forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomfuertes @sindresorhus