Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ink 3 #46

Merged
merged 3 commits into from
Aug 9, 2020
Merged

Upgrade to Ink 3 #46

merged 3 commits into from
Aug 9, 2020

Conversation

vadimdemedes
Copy link

CleanShot 2020-06-23 at 21 16 53

Also rewritten the whole thing using hooks.

@sindresorhus
Copy link
Owner

After searching, if I press Escape to leave, I get this:

❯ node cli.js

› horse



Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in Emoj (created by Context.Consumer)
    in Unknown
    in App

@sindresorhus
Copy link
Owner

Thanks for upgrading this. The changes look great and much more readable now with hooks.

ui.js Outdated Show resolved Hide resolved
ui.js Outdated Show resolved Hide resolved
ui.js Outdated Show resolved Hide resolved
@vadimdemedes
Copy link
Author

Fixed everything, including that warning on exit:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in Emoj (created by Context.Consumer)
    in Unknown
    in App

@sindresorhus sindresorhus merged commit 24db353 into sindresorhus:master Aug 9, 2020
@vadimdemedes vadimdemedes deleted the ink3 branch August 10, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants