Add name to flat configs (#2377)

Co-authored-by: fisker Cheung <lionkay@gmail.com>
sindresorhus · Jun 14, 2024 · ac8536e · ac8536e
1 parent 1490bb6
commit ac8536e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/index.js b/index.js
@@ -47,9 +47,12 @@ const allRules = Object.fromEntries(
 	]),
 );
 
-const createConfig = (rules, isLegacyConfig = false) => ({
-	...(isLegacyConfig ? legacyConfigBase : flatConfigBase),
-	plugins: isLegacyConfig ? ['unicorn'] : {unicorn},
+const createConfig = (rules, flatConfigName = false) => ({
+	...(
+		flatConfigName
+			? {...flatConfigBase, name: flatConfigName, plugins: {unicorn}}
+			: {...legacyConfigBase, plugins: ['unicorn']}
+	),
 	rules: {...externalRules, ...rules},
 });
 
@@ -65,10 +68,10 @@ const unicorn = {
 };
 
 const configs = {
-	recommended: createConfig(recommendedRules, /* isLegacyConfig */ true),
-	all: createConfig(allRules, /* isLegacyConfig */ true),
-	'flat/recommended': createConfig(recommendedRules),
-	'flat/all': createConfig(allRules),
+	recommended: createConfig(recommendedRules),
+	all: createConfig(allRules),
+	'flat/recommended': createConfig(recommendedRules, 'unicorn/flat/recommended'),
+	'flat/all': createConfig(allRules, 'unicorn/flat/all'),
 };
 
 module.exports = {...unicorn, configs};
diff --git a/test/package.mjs b/test/package.mjs
@@ -171,11 +171,11 @@ function getCompactConfig(config) {
 
 test('flat configs', t => {
 	t.deepEqual(
-		getCompactConfig(eslintPluginUnicorn.configs.recommended),
+		{...getCompactConfig(eslintPluginUnicorn.configs.recommended), name: 'unicorn/flat/recommended'},
 		{...eslintPluginUnicorn.configs['flat/recommended'], plugins: undefined},
 	);
 	t.deepEqual(
-		getCompactConfig(eslintPluginUnicorn.configs.all),
+		{...getCompactConfig(eslintPluginUnicorn.configs.all), name: 'unicorn/flat/all'},
 		{...eslintPluginUnicorn.configs['flat/all'], plugins: undefined},
 	);
 });