Add conditional expressions in explicit-length-check rule (#179)

sindresorhus · Jul 28, 2018 · ad1fd85 · ad1fd85
1 parent b546647
commit ad1fd85
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/rules/explicit-length-check.js b/rules/explicit-length-check.js
@@ -136,6 +136,9 @@ const create = context => {
 	return {
 		IfStatement: node => {
 			checkExpression(context, node.test);
+		},
+		ConditionalExpression: node => {
+			checkExpression(context, node.test);
 		}
 	};
 };

diff --git a/test/explicit-length-check.js b/test/explicit-length-check.js
@@ -53,6 +53,7 @@ ruleTester.run('explicit-length-check', rule, {
 		testCase('if (array.length <= 1) {}'),
 		testCase('if (array.length > 1) {}'),
 		testCase('if (array.length < 2) {}'),
+		testCase('const foo = [].length === 0 ? null : undefined'),
 		testCase('array.length', 'not-equal'),
 		testCase('array.length > 0', 'not-equal'),
 		testCase('array.length >= 1', 'not-equal'),
@@ -182,6 +183,11 @@ ruleTester.run('explicit-length-check', rule, {
 			'not-equal',
 			[errorMessages.zeroEqual, errorMessages.nonZeroEqual],
 			'if (array.length === 0 || array.length !== 0) {}'
-		)
+		),
+		testCase(
+			'const foo = [].length ? null : undefined',
+			undefined,
+			[errorMessages.compareToValue]
+		),
 	]
 });