no-await-expression-member: Fix crash on TypeScript parser (#1910)

sindresorhus · Sep 20, 2022 · b002e75 · b002e75
1 parent fde97ab
commit b002e75
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/rules/no-await-expression-member.js b/rules/no-await-expression-member.js
@@ -30,6 +30,7 @@ const create = context => {
 				&& memberExpression.parent.type === 'VariableDeclarator'
 				&& memberExpression.parent.init === memberExpression
 				&& memberExpression.parent.id.type === 'Identifier'
+				&& !memberExpression.parent.id.typeAnnotation
 			) {
 				problem.fix = function * (fixer) {
 					const variable = memberExpression.parent.id;
@@ -52,6 +53,7 @@ const create = context => {
 				&& memberExpression.parent.init === memberExpression
 				&& memberExpression.parent.id.type === 'Identifier'
 				&& memberExpression.parent.id.name === property.name
+				&& !memberExpression.parent.id.typeAnnotation
 			) {
 				problem.fix = function * (fixer) {
 					const variable = memberExpression.parent.id;

diff --git a/test/no-await-expression-member.mjs b/test/no-await-expression-member.mjs
@@ -49,5 +49,14 @@ test.typescript({
 	valid: [
 		'function foo () {return (await promise) as string;}',
 	],
-	invalid: [],
+	invalid: [
+		{
+			code: 'const foo: Type = (await promise)[0]',
+			errors: 1,
+		},
+		{
+			code: 'const foo: Type | A = (await promise).foo',
+			errors: 1,
+		},
+	],
 });