prefer-module: Allow module as TSIndexSignature names or TSTypeAl…

…iasDeclaration ids (#2209) Co-authored-by: fisker Cheung <lionkay@gmail.com>
sindresorhus · Oct 29, 2023 · ea94b3b · ea94b3b
1 parent 61e6601
commit ea94b3b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/rules/ast/is-reference-identifier.js b/rules/ast/is-reference-identifier.js
@@ -115,6 +115,16 @@ function isNotReference(node) {
 			return parent.id === node;
 		}
 
+		// `type Foo = { [Identifier: string]: string }`
+		case 'TSIndexSignature': {
+			return parent.parameters.includes(node);
+		}
+
+		// `type Identifier = Foo`
+		case 'TSTypeAliasDeclaration': {
+			return parent.id === node;
+		}
+
 		case 'TSPropertySignature': {
 			return parent.key === node;
 		}

diff --git a/rules/utils/is-shadowed.js b/rules/utils/is-shadowed.js
@@ -25,7 +25,7 @@ function isShadowed(scope, node) {
 	const reference = findReference(scope, node);
 
 	return (
-		reference?.resolved
+		Boolean(reference?.resolved)
 		&& reference.resolved.defs.length > 0
 	);
 }

diff --git a/test/prefer-module.mjs b/test/prefer-module.mjs
@@ -266,6 +266,17 @@ test.snapshot({
 	],
 });
 
+test.typescript({
+	valid: [
+		'type module = number[];',
+		'type ModuleRegistry = { [module: string]: string };',
+		'const module = 1; type ModuleRegistry = { [module: string]: string };',
+		'type module = number[]; type ModuleRegistry = { [module: string]: string };',
+		'type ModuleRegistry = { [exports: string]: string };',
+	],
+	invalid: [],
+});
+
 // `.cjs` file
 test.snapshot({
 	valid: [