Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-spread should not report on optional chaining #2298

Closed
JounQin opened this issue Mar 18, 2024 · 1 comment · Fixed by #2304
Closed

prefer-spread should not report on optional chaining #2298

JounQin opened this issue Mar 18, 2024 · 1 comment · Fixed by #2304
Labels
bug help wanted

Comments

@JounQin
Copy link
Contributor

JounQin commented Mar 18, 2024 •
edited
Loading 

scopeManager?.scopes.slice()

The fix will error on runtime:

[...scopeManager?.scopes]
@fisker
Copy link
Collaborator

fisker commented Mar 18, 2024

Note: Add test for (scopeManager?.scopes).slice() when work on it.

@MichaelBlm MichaelBlm mentioned this issue Apr 1, 2024
Merged
MichaelBlm added a commit to MichaelBlm/eslint-plugin-unicorn that referenced this issue Apr 3, 2024
@MichaelBlm
should not report on optional chaining (sindresorhus#2298)
85947a0
MichaelBlm added a commit to MichaelBlm/eslint-plugin-unicorn that referenced this issue Apr 3, 2024
@MichaelBlm
should not report on optional chaining (sindresorhus#2298)
0b9a6e0
MichaelBlm added a commit to MichaelBlm/eslint-plugin-unicorn that referenced this issue Apr 3, 2024
@MichaelBlm
should not report on optional chaining (sindresorhus#2298)
879bb36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [2298] prefer-spread: should not report on optional chaining MichaelBlm/eslint-plugin-unicorn
2 participants
@fisker @JounQin