Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit-length-check: Support Vue SFC files #1360

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jun 17, 2021

Can we accept this?

@sindresorhus sindresorhus changed the title explicit-length-check: Work for Vue SFC files explicit-length-check: Support Vue SFC files Jun 17, 2021
@sindresorhus sindresorhus merged commit 9199611 into sindresorhus:main Jun 17, 2021
@sindresorhus
Copy link
Owner

sindresorhus commented Jun 17, 2021

Sure! 👍

@fisker fisker deleted the explicit-length-check-vue branch June 17, 2021 05:40
@fisker
Copy link
Collaborator Author

fisker commented Jun 17, 2021

Do you think we should make all rule work for Vue SFC? We can add one line here.

@fisker
Copy link
Collaborator Author

fisker commented Jun 17, 2021

Let's start with some other rules first, I'll send more PRs

@sindresorhus
Copy link
Owner

Do you think we should make all rule work for Vue SFC?

I don't mind. Vue is quite popular, so it's gonna help a lot of people.

@fisker
Copy link
Collaborator Author

fisker commented Jun 17, 2021

I'm worried about auto-fix for some rule, for example prefer-string-replace-all, we'll fix <div v-if='foo.replace(/a/g, "")' to <div v-if='foo.replaceAll('a', "")', but we can't use single quote for the fix, it's in single quoted attribute, so let's start with some safe rules first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants