Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent-abbreviations: Add def #1402

Merged
merged 2 commits into from
Jul 8, 2021
Merged

prevent-abbreviations: Add def #1402

merged 2 commits into from
Jul 8, 2021

Conversation

dangowans
Copy link
Contributor

Just added eslint-plugin-unicorn to my project, and while straightening out my code, I noticed I used "def" as an abbreviation. Not sure if it means "definition" to everyone else, but it does to me, : )

@sindresorhus sindresorhus changed the title Update abbreviations: def -> definition prevent-abbreviations: Add def Jul 6, 2021
@fisker
Copy link
Collaborator

fisker commented Jul 7, 2021

I think it could be jQuery.Deferred too.

@fisker
Copy link
Collaborator

fisker commented Jul 7, 2021

Maybe also define()?

@dangowans
Copy link
Contributor Author

I could see define. Maybe less on defer or deferred, but that's just me.

I can update the pull request with the others, or is there kind of a limit like, if there's three or more possibilities, the abbreviation shouldn't be included because it's no longer useful?

@fisker
Copy link
Collaborator

fisker commented Jul 7, 2021

We can add them all, still useful, just can't do auto fix.

@dangowans
Copy link
Contributor Author

On a side note, I see there is el and elem for element, but not ele. Not sure that's on purpose, but I can add it as well in this or another pull request.

@sindresorhus
Copy link
Owner

On a side note, I see there is el and elem for element, but not ele. Not sure that's on purpose, but I can add it as well in this or another pull request.

I have never seen ele, personally.

@dangowans
Copy link
Contributor Author

I have never seen ele, personally.

No worries. It's all over my codebase, but it's easy enough to add my own replacement. : )

@sindresorhus sindresorhus merged commit f783472 into sindresorhus:main Jul 8, 2021
@dangowans dangowans deleted the patch-1 branch July 8, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants