-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable require-post-message-target-origin
for TypeScript files
#1415
Conversation
@@ -102,6 +102,7 @@ | |||
"eslint-remote-tester-results" | |||
], | |||
"rules": { | |||
"quotes": ["error", "single"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the default value is double
.
Let's skip it in code, like this, eslint-plugin-unicorn/rules/prefer-module.js Line 217 in c193e1e
|
Users can still enable Personally, I don't think hard-coded extensions in |
I have no idea why |
Because we use this recommended config to generate readme
So overrides should be in it, this is also why I suggest to use |
Then I'd prefer regenerating |
@fisker Besides, We can have a virtual filename
|
Good point. 👍 |
require-post-message-target-origin
for TypeScript files
close #1396