Add prefer-node-append rule
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new entry in index.js for prefer-node-append. - Added a test for prefer-node-append.
|
Need to add the rule to readme.md |
MrHen
reviewed
Nov 3, 2018
sindresorhus
reviewed
Nov 3, 2018
added 3 commits
November 4, 2018 01:07
Replace property at node level instead of constructing the fix manually.
- invalid case of node.appendChild() - invalid case of node.appendChild(null) - valid case of node.append() - valid case of node.append(null) - valid case of appending multiple nodes
- entry in usage section of readme - entry in rules section of readme - new rule doc for prefer-node-append
|
All changes requested for are done |
sindresorhus
changed the title
prefer-node-append rule
sindresorhus
approved these changes
Dec 29, 2018
futpib
approved these changes
Dec 29, 2018
|
Nice work, @nikhilsaldanha :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new entry in index.js for prefer-node-append.
Added a test for prefer-node-append.
closes #170