expiring-todo-comments: Do not normalize package.json (#1871)
#2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
approved these changes
Dec 22, 2022
fisker
reviewed
Dec 22, 2022
schmkr
force-pushed
the
disable-normalize-package-json
branch
from
a612b2b
to
02af0c6
Compare
fisker
approved these changes
Dec 22, 2022
|
@fisker thanks for the approval. I see a check is failing, but not too familiar with this project to identify if this is indeed a result of the changes in this PR. Do you know? |
Not related. |
|
Thanks for that confirmation. What is now the next step, what is still needed to get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #1871, this PR disables normalizing the package.json data, so invalid names (or other properties) in the packages.json will not cause EsLint to break when using this plugin.