Refactor: remove is-builtin-module dep
#2475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
is-builtin-module depis-builtin-module dep
zanminkian
force-pushed
the
refactor/remove
branch
from
9b199ca to
e469604
Compare
fregante
approved these changes
Oct 14, 2024
|
The built-in method matches on a list of APIs that depend on which Node.js version the linter is running on. This can create inconsistent results, meaning it can pass locally, but fail in CI, etc. I think it's better to just wait and then update to https://github.com/sindresorhus/is-builtin-module v4 when we can require ESM, as it uses a static list. |
|
Using static list seems reasonable. I think we should progressively migrate the rules to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.