Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all ports used by process #47

Merged
merged 2 commits into from
May 16, 2018
Merged

Display all ports used by process #47

merged 2 commits into from
May 16, 2018

Conversation

kevva
Copy link
Contributor

@kevva kevva commented Mar 22, 2018

screen shot 2018-03-22 at 13 14 26

Fixes #39.

@sindresorhus
Copy link
Owner

Looks good. Can you fix the conflict?

@kevva
Copy link
Contributor Author

kevva commented Mar 22, 2018

Yup, what do you want to do with the truncating of the name? Currently it looks like this for Google Chrome:

screen shot 2018-03-22 at 13 58 13

@kevva kevva force-pushed the return-all-ports branch from 73a5b68 to a496b89 Compare March 22, 2018 13:01
@sindresorhus
Copy link
Owner

I think we just limit it to the width of the terminal and just do after. No point in showing this many ports. Could maybe use https://github.com/sindresorhus/cli-truncate

@sindresorhus
Copy link
Owner

sindresorhus commented Mar 22, 2018

Hmm, or not. We should truncate it on spaces, not in the middle of a port.

@kevva
Copy link
Contributor Author

kevva commented Mar 22, 2018

Hmm, or not. We should truncate it on spaces, not in the middle of a port.

Would this make sense as an option in https://github.com/sindresorhus/cli-truncate? Or maybe add space to the position option.

@sindresorhus
Copy link
Owner

sindresorhus commented Mar 22, 2018

Would this make sense as an option in sindresorhus/cli-truncate?

Yes, something like {preferBreakingOnSpaces: true}. If there are no spaces or it has to break more than half the line to do it, it should just truncate normally. Need a better name than preferBreakingOnSpaces though.

@sindresorhus
Copy link
Owner

cli-truncate issue: sindresorhus/cli-truncate#8

@sindresorhus sindresorhus merged commit 9363113 into master May 16, 2018
@sindresorhus sindresorhus deleted the return-all-ports branch May 16, 2018 17:57
sindresorhus added a commit that referenced this pull request May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants