Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --force-after-timeout / -t option #80

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

stroncium
Copy link
Contributor

@stroncium stroncium commented Jul 8, 2021

Add option --force-timeout N/-t N, to force kill processes which didn't exit within timeout seconds.

In interactive mode,wait up to 3 seconds for processes to exit, then prompt user to force kill surviving processes.

Fixes #42
Requires sindresorhus/fkill#54


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@sindresorhus
Copy link
Owner

interactive.js Outdated Show resolved Hide resolved
interactive.js Outdated Show resolved Hide resolved
interactive.js Outdated Show resolved Hide resolved
interactive.js Outdated Show resolved Hide resolved
interactive.js Outdated Show resolved Hide resolved
@stroncium stroncium force-pushed the fix42 branch 3 times, most recently from 0516b5f to 5a75f61 Compare July 9, 2021 11:27
@stroncium
Copy link
Contributor Author

Found a bug introduced in fkill(windows doesn't throw errors for non-existing processes when using force), working on it.
Affects tests here.

@stroncium
Copy link
Contributor Author

Should work after sindresorhus/fkill#55

@sindresorhus
Copy link
Owner

Should work after sindresorhus/fkill#55

It's released. You need to bump the version.

@sindresorhus sindresorhus merged commit 7eeda5d into sindresorhus:main Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process is not killed
2 participants