Fix _pagination not falling back to defaults

sindresorhus · Feb 8, 2020 · ff1dba1 · ff1dba1
1 parent 3c6ca29
commit ff1dba1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/source/normalize-arguments.ts b/source/normalize-arguments.ts
@@ -200,7 +200,7 @@ export const preNormalizeArguments = (options: Options, defaults?: NormalizedOpt
 
 	// `options._pagination`
 	if (is.object(options._pagination)) {
-		if (defaults && !(Reflect.has(options, 'pagination') && is.undefined(options._pagination))) {
+		if (defaults && !(Reflect.has(options, '_pagination') && is.undefined(options._pagination))) {
 			options._pagination = {
 				...defaults.pagination,
 				...options._pagination

diff --git a/test/pagination.ts b/test/pagination.ts
@@ -47,6 +47,14 @@ test('retrieves all elements', withServer, async (t, server, got) => {
 	t.deepEqual(result, [1, 2]);
 });
 
+test('points to defaults when extending Got without custom `_pagination`', withServer, async (t, server, got) => {
+	attachHandler(server, 2);
+
+	const result = await got.extend().paginate.all('');
+
+	t.deepEqual(result, [1, 2]);
+});
+
 test('filters elements', withServer, async (t, server, got) => {
 	attachHandler(server, 3);