Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Runkit example #1253

Merged
merged 2 commits into from
May 12, 2020
Merged

Add a Runkit example #1253

merged 2 commits into from
May 12, 2020

Conversation

Giotino
Copy link
Collaborator

@Giotino Giotino commented May 12, 2020

Checklist

  • I have read the documentation.

Similar to the already existing example

const got = require("got");
const ISS = "http://api.open-notify.org/iss-now.json";

(await got(ISS, { json: true })).body.iss_position;

But compatible with the latest version of Got

#1072

Co-authored-by: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
@Giotino
Copy link
Collaborator Author

Giotino commented May 12, 2020

Does the file need to be included in files in package.json?

I don't know and I can't find any info about that...

@szmarczak szmarczak changed the title NPM Runkit example Add a Runkit example May 12, 2020
@szmarczak szmarczak merged commit 48bbb36 into sindresorhus:master May 12, 2020
@szmarczak
Copy link
Collaborator

Let's give it a try :)

@sindresorhus
Copy link
Owner

I guess this is better than a broken example, but the existing example was not really a good one. I was hoping we could add something better.

@Giotino
Copy link
Collaborator Author

Giotino commented May 12, 2020

I guess this is better than a broken example, but the existing example was not really a good one. I was hoping we could add something better.

Let's say that what we have done here is only a test in order to check if Runkit load our script, now we can work on a better example.

@szmarczak szmarczak mentioned this pull request May 13, 2020
2 tasks
@Giotino Giotino deleted the issue-1072 branch June 5, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants