fix hangs with CLI commands waiting for input #115
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous .resume() and .pipe() did not close the stdin stream on the child process which made scripts that wait for data on stdin hang. The fix manually sends all stdin chunks to the child and ensures that the stream is always closed afterwards.
There might be a cleaner solution using flowing mode, but I'm not sure how to ensure closure of the target WriteStream when using
.pipe()
.This should properly solve these issue: