Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows for resolve path #80

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

gucong3000
Copy link
Contributor

No description provided.

@sindresorhus
Copy link
Owner

Is there any test failing on Windows before this change? If not, would you mind adding a test for this?

@gucong3000
Copy link
Contributor Author

Is there any test failing on Windows before this change?

Yes.

title: should filter relative paths that leave current directory tree
https://github.com/sindresorhus/gulp-filter/blob/master/test.js#L164

@gucong3000
Copy link
Contributor Author

  2) filter() should filter relative paths that leave current directory tree:

      Uncaught AssertionError [ERR_ASSERTION]: 0 == 1
      + expected - actual

      -0
      +1

      at StreamFilter.stream.on (test.js:174:11)
      at endReadableNT (node_modules\streamfilter\node_modules\readable-stream\lib\_stream_readable.js:992:12)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

@sindresorhus sindresorhus merged commit d7cf3d4 into sindresorhus:master Aug 2, 2017
@gucong3000 gucong3000 deleted the patch-1 branch August 2, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants