Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is.iterable and is.asyncIterable TypeScript types #149

Merged

Conversation

sdotson
Copy link
Contributor

@sdotson sdotson commented Jan 6, 2022

Fixes #128

Also added is.iterableIterator.

@sindresorhus
Copy link
Owner

From the issue:

And asyncIterable should be fixed too.

@sindresorhus
Copy link
Owner

Also added is.iterableIterator.

I'm not sure I see the use-case for this one. And if there is one, it should be a separate pull request.

@sindresorhus sindresorhus changed the title Fix is.iterable and add is.iterableIterator Fix is.iterable Jan 6, 2022
@sdotson sdotson force-pushed the make-is-iterable-return-iterable branch from b90a57f to 7896785 Compare January 7, 2022 14:17
@sdotson
Copy link
Contributor Author

sdotson commented Jan 7, 2022

Thank you for the feedback. I think I've addressed it with the latest commit, but let me know if there are further concerns.

@sindresorhus sindresorhus changed the title Fix is.iterable Fix is.iterable and is.asyncIterable TypeScript types Jan 7, 2022
@sindresorhus sindresorhus merged commit b16092a into sindresorhus:main Jan 7, 2022
younho9 pushed a commit to younho9/is that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is.iterable returns IterableIterator instead of Iterable
2 participants