Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .nonEmptyStringAndNotWhitespace() #161

Merged
merged 10 commits into from
Feb 25, 2022
Merged

Add .nonEmptyStringAndNotWhitespace() #161

merged 10 commits into from
Feb 25, 2022

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Feb 22, 2022

as described here #158

@ivankatliarchuk ivankatliarchuk changed the title added nonEmptyStringAndNotWhitespace add nonEmptyStringAndNotWhitespace Feb 22, 2022
@ivankatliarchuk ivankatliarchuk changed the title add nonEmptyStringAndNotWhitespace add nonEmptyStringAndNotWhitespace Feb 22, 2022
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
test/test.ts Outdated
Comment on lines 1447 to 1449
t.throws(() => {
assert.nonEmptyStringAndNotWhitespace(String());
});
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

test/test.ts Outdated
@@ -1436,6 +1436,22 @@ test('is.emptyStringOrWhitespace', t => {
});
});

test('is.nonEmptyStringAndNotWhitespace', t => {
t.false(is.nonEmptyStringAndNotWhitespace(' '));
t.false(is.nonEmptyStringAndNotWhitespace(String()));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

ivankatliarchuk and others added 5 commits February 22, 2022 18:24
removed 2

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
remove emtpy values in example array

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus sindresorhus changed the title add nonEmptyStringAndNotWhitespace Add .nonEmptyStringAndNotWhitespace() Feb 25, 2022
@sindresorhus sindresorhus merged commit 23cf074 into sindresorhus:main Feb 25, 2022
@ivankatliarchuk ivankatliarchuk deleted the chore/nonEmptyStringAndNotWhitespace branch February 25, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants