Fix type guards for assert.{truthy,falsy,nan}
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix that type guards for `assert.truthy` and `assert.falsy` are not working since they are declared to be `unknown` type. Also change type guard for `assert.nan` from `unknown` type to `number` type, as `NaN` is actually of type `number`.
This also align the generic and parameter type of `is.falsy` with `assert.falsy`.
Add statements in test/test.ts and tests that if typescript compiler can compile the file to check if type guard and narrowing are working as expected.
sindresorhus
requested changes
Jul 16, 2023
wdzeng
force-pushed
the
main
branch
4 times, most recently
from
eed18f1 to
18cd149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that type guards for
assert.truthyandassert.falsyare not working since they are declared to beunknowntype.Also change type guard for
assert.nanfromunknowntype tonumbertype, asNaNis actually of typenumber.Closes #186