Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is.TupleLike #189

Merged

Conversation

Myfeetarefreezing
Copy link
Contributor

@Myfeetarefreezing Myfeetarefreezing commented Jul 21, 2023

#156 used this as reference to the interface

@Myfeetarefreezing Myfeetarefreezing force-pushed the add-is.TupleLike#156 branch 2 times, most recently from da74c93 to 5851019 Compare July 21, 2023 19:15
@Myfeetarefreezing Myfeetarefreezing changed the title Add is.TupleLike #156 Add is.TupleLike Jul 21, 2023
@sindresorhus
Copy link
Owner

You need to update the readme.

@Myfeetarefreezing
Copy link
Contributor Author

Hope the .md is clear enough

@sindresorhus
Copy link
Owner

Thanks. Can you also add a few type tests to ensure the types are correctly narrowed?

Example:

is/test/test.ts

Lines 1567 to 1575 in 278e0e9

{
const mixed = ['🦄', 'unicorn', 1, 2];
const function_ = (value: string | number) => value;
assert.nonEmptyArray(mixed);
const value = mixed[0];
function_(value);
}

test/test.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@gioragutt gioragutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, GJ @Myfeetarefreezing, hope your feet get warmer 👍🏻

@Myfeetarefreezing
Copy link
Contributor Author

LGTM, GJ @Myfeetarefreezing, hope your feet get warmer 👍🏻

A never ending struggle..

@sindresorhus sindresorhus merged commit 3868f47 into sindresorhus:main Jul 23, 2023
@gioragutt
Copy link
Collaborator

Congrats @Myfeetarefreezing, thank you for your contribution 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants