Give better assertion messages for assert.all & assert.any #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Aug 8, 2023
sindresorhus
reviewed
Aug 8, 2023
source/index.ts
Outdated
| return Array.from(new Set(values)); | ||
| } | ||
|
|
||
| function joinWithWord(values: string[], word: 'and' | 'or'): string { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Good idea, I switched to using Intl.ListFormat but ran into an issue where the type definitions did not exist for it.
I updated tsconfig.json to target ES2021.
…all & assert.any (Fixes sindresorhus#107)
bjornstar
force-pushed
the
is-any-all-descriptions
branch
from
8ca56da to
cae2664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
I improved the output slightly for the type assertion messages and added tests for the improvements.