Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Ky as a ES2015 module #23

Closed
wants to merge 2 commits into from
Closed

Export Ky as a ES2015 module #23

wants to merge 2 commits into from

Conversation

dangdennis
Copy link
Contributor

@dangdennis dangdennis commented Sep 8, 2018 •
edited by sindresorhus
Loading

Use the now standardized es6 export syntax. You can export the defined default, classes, and any extra function as usual.

Fixes #24

@dangdennis dangdennis closed this Sep 8, 2018
@dangdennis
Copy link
Contributor Author

dangdennis commented Sep 9, 2018 •
edited
Loading

#24

Requires some work dealing with exporting the correct api for tests and use. May I have guidance here please? 😄

@dangdennis dangdennis reopened this Sep 9, 2018
@sindresorhus sindresorhus changed the title Feat: convert cjs -> es6 modules Export Ky as a ES2015 module Sep 10, 2018
@sindresorhus
Copy link
Owner

Good idea! I think extend should be part of the instance and not be an individual export.

@callumlocke callumlocke mentioned this pull request Oct 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangdennis @sindresorhus