Avoid linkifying trailing question mark

[karlhorky]

Addition to #49 for #26

• Avoid linkifying trailing period #49 (comment)

cc @fregante

[karlhorky]

Oh, looks like snapshot needs to be updated:

linkifyUrlsToHtml: supports CJK URLs

  test.js:148

   1[47](https://github.com/sindresorhus/linkify-urls/actions/runs/11767099536/job/32775410309?pr=50#step:5:48):     t.snapshot(linkify('https://github.com/scarf005/hangul-test/wiki/한…
   1[48](https://github.com/sindresorhus/linkify-urls/actions/runs/11767099536/job/32775410309?pr=50#step:5:49):     t.snapshot(linkify('https://www.例.jp?'));                          
   1[49](https://github.com/sindresorhus/linkify-urls/actions/runs/11767099536/job/32775410309?pr=50#step:5:50):   });                                                                  

  Did not match snapshot

  Difference (- actual, + expected):

  - '<a href="https://www.例.jp">https://www.例.jp</a>?'
  + '<a href="https://www.例.jp?">https://www.例.jp?</a>'

  › file://test.js:148:5



  linkifyUrlsToDom: supports CJK URLs

  test.js:148

   147:     t.snapshot(linkify('[https://github.com/scarf005/hangul-test/wiki/한…](https://github.com/scarf005/hangul-test/wiki/%ED%95%9C%E2%80%A6)
   148:     t.snapshot(linkify('[https://www.例.jp?](https://www.xn--fsq.jp/?)'));                          
   149:   });                                                                  

  Did not match snapshot

  Difference (- actual, + expected):

  - 'DocumentFragment: <a href="[https://www.例.jp](https://www.xn--fsq.jp/)">[https://www.例.jp](https://www.xn--fsq.jp/)</a>?'
  + 'DocumentFragment: <a href="[https://www.例.jp?](https://www.xn--fsq.jp/?)">[https://www.例.jp?](https://www.xn--fsq.jp/?)</a>'

  › file://test.js:148:5

  ─

  2 tests failed

I guess the snapshot update will need to be done locally, since the AVA snapshot format is binary and I can't edit by hand in the GitHub PR

[fregante]

The snapshots can be updated via npx ava -u I think. One is needed for this PR

[fregante]

Let's just use a regex to extract it here, like:

const punctuation = trailingPunctuationRegex.exec(href) ?? '';
if (punctuation) {
  href = href.slice(0, -1);
}

[karlhorky]

Done in 669b814 and 509b9e6

[karlhorky]

@fregante Made the suggested change and updated the snapshot

[karlhorky]

@fregante I guess it needs to access the first array element with optional chaining (suggestion already committed)

Suggested change

	const punctuation = /[.?]$/.exec(href) ?? '';
	const punctuation = /[.?]$/.exec(href)?.[0] ?? '';

Repl:

/[.?]$/.exec('asdf.')
> ['.', index: 4, input: 'asdf.', groups: undefined]
/[.?]$/.exec('asdf.').toString()
> '.'

[karlhorky]

Oh TIL actually not necessary!

(because of the .toString() method on the .exec() result)

Repl:

'asdf' + /[.?]$/.exec('asdf.')
> 'asdf.'
/[.?]$/.exec('asdf.').toString()
> '.'

I think it's probably still more expressive with the ?.[0]

But if preferred, we can rely on the .toString() "magic" and I can revert this change

[fregante]

Works for me as is. Let's wait for Sindre

[karlhorky]

Thanks for the review and merge!