Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal - Disable Indent #240

Closed
dylanarmstrong opened this issue Jun 9, 2023 · 12 comments · Fixed by #241
Closed

Feature Proposal - Disable Indent #240

dylanarmstrong opened this issue Jun 9, 2023 · 12 comments · Fixed by #241

Comments

@dylanarmstrong
Copy link
Contributor

dylanarmstrong commented Jun 9, 2023

I'd like the option to disable the indent.

  Some descriptive text
  Usage:
    $ application

Is the default, and I'd like to make it indented to 0.

Proposal:
Add indent as an option with a default value of 2.

I have submitted a PR for this.

@voxpelli
Copy link
Contributor

voxpelli commented Jun 9, 2023

Can you give a motivation why you want to have a different indent?

Is it personal taste or it would give some tangible improvements from your point of view?

@dylanarmstrong
Copy link
Contributor Author

Just personal taste, I prefer that my help descriptions are left aligned in terminal. This adds the ability to adjust it.

@voxpelli
Copy link
Contributor

voxpelli commented Jun 9, 2023

Lets see what the maintainer thinks then, but just a reflection: There are no other such presentation options in Meow currently, and I'm personally not sure if it would be good to open that box of making presentation customizable to personal taste. Lots of options for little gain?

@dylanarmstrong
Copy link
Contributor Author

Interesting, I hadn’t actually realized.

How frequently do they check PRs? I have another one against node-defaults too.

@sindresorhus
Copy link
Owner

sindresorhus commented Aug 30, 2023

Accepted.

/* @default 2 */
indentHelp: number | false

@sindresorhus
Copy link
Owner

How frequently do they check PRs? I have another one against node-defaults too.

Every day, but I have been at bit overwhelmed with pull request during the summer.

@sindresorhus
Copy link
Owner

indentHelp or helpIndent? I think indent is too ambigious. We don't indent --version, for example.

@voxpelli
Copy link
Contributor

voxpelli commented Aug 30, 2023 via email

@dylanarmstrong
Copy link
Contributor Author

dylanarmstrong commented Aug 30, 2023

Thanks, I've updated PR to helpIndent and rebased against main.

Oops, apologies @sindresorhus, just realized that in your example you used indentHelp. I'm fine with either, which would you prefer?

@sindresorhus
Copy link
Owner

Let's go with helpIndent.

@dylanarmstrong
Copy link
Contributor Author

Just to clarify, this was updated in the PR.

@dylanarmstrong
Copy link
Contributor Author

dylanarmstrong commented Feb 4, 2024

Hi, have you had a chance to look at the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants