data URI support #6
Conversation
| @@ -2,10 +2,15 @@ | |||
| 'use strict'; | |||
| const meow = require('meow'); | |||
| const opn = require('opn'); | |||
| const getStdin = require('get-stdin'); | |||
| const tempWrite = require('temp-write'); | |||
| const dataUriToBuffer = require('data-uri-to-buffer'); | |||
There was a problem hiding this comment.
maybe require those when needed to reduce startup time ?
There was a problem hiding this comment.
Premature optimization is the root of all evil.
http://c2.com/cgi/wiki?PrematureOptimization
A few requires have no noticeable impact.
|
I think you misunderstood me. There's no need for data URI support. It can just be stdin. Could just be Note, not URL, but the content as stdin. |
No
That was my original request see sindresorhus/open#24
Yes and the PR is at #5 |
No, that PR adds support for reading URL from stdin. That isn't very useful as you can already do that with |
|
@sindresorhus right my bad, understood |
|
It will probably need an We could default to |
|
Closing in favor of #7. |
this PR includes commit for stdin support #5 as well