Fix concurrency control in pMapIterable
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
// @Richienb |
Richienb
suggested changes
Aug 15, 2024
| return; | ||
| } | ||
|
|
||
| const promise = (async () => { | ||
| pendingPromisesCount++; |
There was a problem hiding this comment.
Perhaps we could be even more explicit by moving this up an additional level?
|
I think it would have taken me some hours to find this fix, so good spotting! 🎉 |
|
Your commit at dmitri-gb@8df3b16 reminded me that the reason why I initially incremented the count later was an attempt to avoid the exact issue it solved. It looks like a better solution would be to have two backpressures, one for function inputs and one for pending promises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76