Await values before passing them to mapper, refactor TS definition to CJS compatible export
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion to CJS compatible export
|
We should not await any keys that are promises. Only the values. |
|
Is this good to merge now? |
|
Yes. |
|
Sorry, forgot to ask. Is this a breaking change? |
|
Yes, for TS and for JS users alike. |
sindresorhus
changed the title
mapper, refactor TS definition to CJS compatible exportmapper, refactor TS definition to CJS compatible export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.
I have question here: A
Mapcan havePromises as values but also as keys. Should I handle the possibility of keys asPromises and resolve them before passing tomapper? If yes, should the resultingMapcontain the resolved values as keys or the originalPromises?