-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mapping to preserve statically known types #17
Conversation
It sounds like from #16 that the existing type should be changed instead of just adding an overload. |
Friendly bump :) |
Holy fuck — how do you manage to keep track of stale PRs? 😲 I'll try to get to it later today. Thanks for the ping. 😊 |
This one had open in an old tab. But I check https://github.com/search?o=asc&q=is:pr+is:open+archived:false+user:@me&s=updated&type=Issues once in a while. |
Looking at this again, I think the original types need to be kept in order to keep full support for I may be wrong though. But as it stands, this PR already significantly improves the usability of the types for the happy path (no What do you think? /cc @novemberborn in case you are interested as well |
Co-authored-by: Pedro Augusto de Paula Barbosa <papb1996@gmail.com>
Tests are failing (yay!) and I will try to look at them locally some time today. tbh this PR started as a mere drive-by quick fix via the GitHub web UI, but it seems I need to grant it some time in a real IDE. 😄 |
Bump :) |
Fixes #16.