Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bits option #53

Merged
merged 10 commits into from
Jul 26, 2019
Merged

Add bits option #53

merged 10 commits into from
Jul 26, 2019

Conversation

montyanderson
Copy link
Contributor

Switch units based on boolean 'bits' flag.

@sindresorhus
Copy link
Owner

What’s the use-case? Would be good to include that in the docs for the option.

@super3
Copy link

super3 commented Jul 10, 2019

@sindresorhus Download/upload speed is usually represented in bits/s vs bytes/s. We are using this for logging on YaCDN:

{ n: 14291272,
4|yacdn-5  |   url:
4|yacdn-5  |    'http://meowbaari.com/wp-content/uploads/2016/06/1464933654_cat_sleep.png',
4|yacdn-5  |   referer: undefined,
4|yacdn-5  |   size: '3.05 kB',
4|yacdn-5  |   time: '2101ms',
4|yacdn-5  |   *speed: '1.45 kbit/s'* }

@sindresorhus sindresorhus changed the title Add bits support Add bits option Jul 10, 2019
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Download/upload speed is usually represented in bits/s vs bytes/s. We are using this for logging on YaCDN:

👍 Makes sense. Would be good to include the use-case about speed in the docs for the option.

@super3
Copy link

super3 commented Jul 18, 2019

@sindresorhus Are the changes satisfactory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants