Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package fails to minify #31

Closed
danias opened this issue Sep 23, 2018 · 2 comments
Closed

Package fails to minify #31

danias opened this issue Sep 23, 2018 · 2 comments

Comments

@danias
Copy link

danias commented Sep 23, 2018

Failed to minify the code from this file:

./node_modules/pretty-ms/index.js:4 

Facebook recommends to publish code on npm as ES5 at least for a few more years.

Read more here: http://bit.ly/2tRViJ9

@danias
Copy link
Author

danias commented Sep 23, 2018

Actually it is (also) a parse-ms issue

@sindresorhus
Copy link
Owner

This module mainly targets Node.js, not the browser. It's up to you to transpile it with Babel if you want to use it in the browser. You can find a more detailed explanation here: sindresorhus/ama#446

I'm sorry that create-react-app is lacking in this aspect, but it's up to them to support the community. Each package should not be required to specially support create-react-app. Please do open an issue on create-react-app about this pain point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants