Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-run build fails because of pretty-ms module #231

Closed
bherr2 opened this issue Nov 15, 2018 · 3 comments
Closed

client-run build fails because of pretty-ms module #231

bherr2 opened this issue Nov 15, 2018 · 3 comments
Assignees
Labels
Bug Something isn't working SMM Tasks for SMM to complete

Comments

@bherr2
Copy link
Member

bherr2 commented Nov 15, 2018

When trying to build the client-run I get this error:

$ npm run build

> client-run@0.1.0 build /home/bherr/workspaces/aisl/xmacroscope/packages/client-run
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

        ./node_modules/pretty-ms/index.js:4

Read more here: http://bit.ly/2tRViJ9

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! client-run@0.1.0 build: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the client-run@0.1.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

I believe its related to this: sindresorhus/pretty-ms#31

This is important to fix asap as I am building the server to deploy here.

@bherr2 bherr2 added Bug Something isn't working SMM Tasks for SMM to complete labels Nov 15, 2018
@bryankennedy bryankennedy changed the title client-run build fails client-run build fails because of pretty-ms module Nov 15, 2018
@bryankennedy
Copy link
Contributor

pretty-ms is focused on the Node environment and not web JS. As a result it seems like it doesn't support transpiling within our ES6 project very well. We're only using it to convert milliseconds to human readable format for the Timer component. That component is only displaying the timer conditionally. In its current usage, we don't need to display it on any of the exhibit screens. So for now I'm just going to remove this module to address this issue.

bryankennedy added a commit that referenced this issue Nov 15, 2018
Pretty-ms is used to clean up Milliseconds display. It's causing build
problems (#231) with our build process and we're not currently using it,
so I'm removing it from the Timer component.
@bryankennedy
Copy link
Contributor

@bherr2 this commit fixes the issue for me. Close if you can confirm.

@bryankennedy
Copy link
Contributor

Bruce confirmed this is working on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SMM Tasks for SMM to complete
Projects
None yet
Development

No branches or pull requests

3 participants