Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dot-prop to version 7.x #21

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Sep 21, 2022

This should not be a breaking change since the breaking changes in dot-prop 7.0.0 doesn't apply to this package

@sindresorhus sindresorhus merged commit 34c3c1a into sindresorhus:main Sep 21, 2022
@LinusU
Copy link
Contributor Author

LinusU commented Sep 21, 2022

@sindresorhus I think that I missed something here, sorry about that!

This might be a breaking change:

Accessing array indices were never documented in previous versions, but it worked as 'a.0'. This no longer works. Use 'a[0]' instead.

Although it wasn't documented so not sure.

For some reason I thought that was in 6.x when I wrote the original description in the PR 🤦‍♂️

@LinusU LinusU deleted the dot-prop-7 branch September 21, 2022 13:12
@sindresorhus
Copy link
Owner

I don't consider that a breaking change as it was indeed never documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants