Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MergeDeep for typescript 5.4 #807

Merged
merged 5 commits into from
Jan 30, 2024
Merged

fix: MergeDeep for typescript 5.4 #807

merged 5 commits into from
Jan 30, 2024

Conversation

skarab42
Copy link
Collaborator

@skarab42 skarab42 commented Jan 29, 2024

Closes #806
Fixes #784

@skarab42
Copy link
Collaborator Author

@sindresorhus sindresorhus requested a review from voxpelli January 30, 2024 09:43
Copy link
Collaborator

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work, which is great, a neater solution than mine 👍

source/merge-deep.d.ts Outdated Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 5f6165a into main Jan 30, 2024
12 checks passed
@sindresorhus sindresorhus deleted the fix/merge-deep-ts54 branch January 30, 2024 12:00
@sindresorhus
Copy link
Owner

Thanks for the fix @skarab42. And thanks for the review @voxpelli 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canary: MergeDeep failures in typescript@next not detected by canary tests
4 participants