Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the isNpm() check optional with a flag #122

Closed
alexccl opened this issue Jul 24, 2017 · 0 comments
Closed

Make the isNpm() check optional with a flag #122

alexccl opened this issue Jul 24, 2017 · 0 comments

Comments

@alexccl
Copy link
Contributor

alexccl commented Jul 24, 2017

I am currently working on a project that would still like the notification output when running in a npm script context. Currently we have to make assumptions about how both update-notifier and isNpm are implemented and manually manipulate process.env to work around this issue. This is not ideal.

I wanted to open a PR to add an notifyWithNpm flag to the notify options. Only if explicitly set would the notification still be outputted in an npm context (not break current functionality). Would this be something you all would be open to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant