Add ability to bypass isNpm check with shouldNotifyInNpmScript option
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischah
suggested changes
Oct 18, 2017
There was a problem hiding this comment.
This new option should be documented over here: https://github.com/yeoman/update-notifier#options
mischah
approved these changes
Oct 18, 2017
|
Can you fix the merge conflict? |
index.js
Outdated
| @@ -38,6 +38,7 @@ class UpdateNotifier { | |||
| this.callback = options.callback || (() => {}); | |||
| this.disabled = 'NO_UPDATE_NOTIFIER' in process.env || | |||
| process.argv.indexOf('--no-update-notifier') !== -1; | |||
| this.skipIsNpmCheck = options.shouldNotifyInNpmScript; | |||
There was a problem hiding this comment.
Better to give it the same name in both places:
this.shouldNotifyInNpmScript = options.shouldNotifyInNpmScript;
sindresorhus
changed the title
shouldNotifyInNpmScript option
mischah
approved these changes
Oct 30, 2017
|
Is this waiting on something before being merged? I'd like to use it as well. |
|
I'll go ahead and merge/release this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team and I have run into multiple scenarios where we've wanted to output the update message when running as an npm script. To do this, we've had to dig through the source code, hack environment variables, run this package, and reset environment variables.
This PR include functionality to bypass the isNpm() check. This will not break any existing functionality.
Fixes #122