Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change while loop conditions to fix infinite loop #11

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

nick-mccoy
Copy link
Contributor

@nick-mccoy nick-mccoy commented Sep 6, 2018

The while loop for in_app_events had:

while to_datetime <= stop_datetime

which caused an infinite loop since, once the stream caught up, to_datetime was equal to stop_datetime. Since there is a limit on the requested reports, once the tap would loop until it hit that limit and then receive a 400 and error out.

This changes the loop to

while from_datetime < to_datetime

@nick-mccoy nick-mccoy merged commit eb6698d into master Sep 6, 2018
@nick-mccoy nick-mccoy deleted the fix_infinite_loop branch September 6, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant