Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made timer thread a daemon thread #112

Merged
merged 2 commits into from
Jul 16, 2021
Merged

made timer thread a daemon thread #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
707779f
made timer thread a daemon thread
Jul 16, 2021
4f2f51b
updated version
Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 1.4.38
* Makes timer thread a daemon thread so that when main thread exits it's ensured that the process exits [#112](https://github.com/singer-io/tap-salesforce/pull/112)

## 1.4.37
* Remove support for FieldHistoryArchive because we don't query for it properly [#101](https://github.com/singer-io/tap-salesforce/pull/101)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup

setup(name='tap-salesforce',
version='1.4.37',
version='1.4.38',
description='Singer.io tap for extracting data from the Salesforce API',
author='Stitch',
url='https://singer.io',
Expand Down
1 change: 1 addition & 0 deletions tap_salesforce/salesforce/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ def login(self):
finally:
LOGGER.info("Starting new login timer")
self.login_timer = threading.Timer(REFRESH_TOKEN_EXPIRATION_PERIOD, self.login)
self.login_timer.daemon = True # The timer should be a daemon thread so the process exits.
self.login_timer.start()

def describe(self, sobject=None):
Expand Down