Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix login thread #114

Merged
merged 5 commits into from
Jul 28, 2021
Merged

Fix login thread #114

merged 5 commits into from
Jul 28, 2021

Conversation

luandy64
Copy link
Contributor

Description of change

This PR

  • Adds a spike to help understand how daemon threads should work
  • Adds a timeout to all requests made by the tap
  • Adds logging for the type of timeout that occurs

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • I made requests to trigger a ConnectTimeout and ReadTimeout in order to know what errors to catch

Risks

  • Low

Rollback steps

  • revert this branch

@luandy64 luandy64 merged commit fc036ae into master Jul 28, 2021
@luandy64 luandy64 deleted the fix-login-thread branch July 28, 2021 16:04
@luandy64 luandy64 mentioned this pull request Jul 28, 2021
Merged
2 tasks
@dsprayberry dsprayberry mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachharris1 zachharris1 zachharris1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luandy64 @zachharris1