Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump api v52.0 #116

Merged
merged 11 commits into from
Sep 9, 2021
Merged

Bump api v52.0 #116

merged 11 commits into from
Sep 9, 2021

Conversation

zachharris1
Copy link
Contributor

@zachharris1 zachharris1 commented Aug 17, 2021

Description of change

This PR bumps Salesforce api version from 41 > 52. This requires a few changes in the tap, notably salesforce now returns a data type of long, which we cast to an integer. The new api version returns 125 new streams, 119 of which we are able to sync and have been added to the tests. The other 6 streams have been blacklisted because they return a MALFORMED QUERY error or are unsupported by the Bulk api.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

  • Discovery is dynamic, so clients will be able to sync streams we have not tested based on their access levels in salesforce
  • Some streams have changes in permissions, for example 'UserShare'. Clients currently syncing those streams could lose access to them on v52 if they do not have the correct permissions. We plan to notify clients of this change and give them some time to check their permissions before deploying.

Rollback steps

  • revert this branch

@leslievandemark leslievandemark merged commit 1eb7c2b into master Sep 9, 2021
@leslievandemark leslievandemark deleted the bump-api-v52.0 branch September 9, 2021 15:20
@leslievandemark leslievandemark mentioned this pull request Sep 9, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants