Crest Work #142
Merged
Crest Work #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated code to add CRITICAL for multiline error messages * run unittest in CCi * updated config.yml file
* add date windowing * resolved pylint error * resolved pylint error * resolved pylint error * add unittest * added commnets for logic explanation * resolved pylint error * update config.yml * add remaining unittest * add change in bulk * resolved pylint error * update config.yml * added unittest for date window gaps * resolve unittest failure * resolved review comments * resolved pylint duplicate code error Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com>
… API (#138) * Fix Full Table Bookmarking Stratergy for bulk Api * add detialed comments * update config.yml * remove unused pakage * updated unittest Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com>
… Syncs (#135) * added lookback window * resolved pylint and unittest error * resolved unittest error * updated lookback window code * updated lookback code to work for incremental syncs * added some comments * updated comments * added function comments * resolved review comments * addressed review comments * updated lookback window integration test and unittests * Update unit tests to match expected implementation (#141) We do not want to apply the lookback window to the start date * updated the code to use lookback if present * resolved CCi failure and updated README file * set Account as INCREMENTAL before sync * updated state date and fixed pylint error Co-authored-by: Andy Lu <andy@stitchdata.com>
KrisPersonal
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(write a short description here or paste a link to JIRA)
CRITICALerror messages #137QA steps
Risks
Rollback steps