Prevent exceptions during login from killing the thread #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmosorast
reviewed
Dec 18, 2017
| self.access_token = auth['access_token'] | ||
| self.instance_url = auth['instance_url'] | ||
| except Exception as e: | ||
| raise Exception(str(e) + ", Response from Salesforce: {}".format(resp.text)) from e |
There was a problem hiding this comment.
resp.text could possibly throw if session.post throws to get us into this. It's very useful information if it exists, maybe move it into an "if exists" check and add it on if so?
added 2 commits
December 18, 2017 14:58
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't let an exception during the
POSTto kill the thread and prevent it from executing another login.