New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify error handling for http errors #38

Merged

KAllan357 merged 1 commit into master from fix-error-handling

Feb 8, 2018

Contributor

KAllan357 commented Feb 8, 2018

Fixes a bug that looks like:

2018-02-07 10:09:47,268Z    tap -   File "/code/python3.5/site-packages/tap_salesforce/salesforce/exceptions.py", line 17, in __str__
2018-02-07 10:09:47,268Z    tap -     ", Response from Salesforce: {}".format(self.requestException.response.text)
2018-02-07 10:09:47,268Z    tap - AttributeError: 'str' object has no attribute 'response'


          fix error handling http errors

abf8dc5

mdelaurentis approved these changes

View reviewed changes

KAllan357 merged commit bd76adf into master

KAllan357 deleted the fix-error-handling branch

February 8, 2018 20:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet