Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting paragraph with links doesn't linkify #1432

Closed
jezell opened this issue Oct 18, 2023 · 10 comments
Closed

Pasting paragraph with links doesn't linkify #1432

jezell opened this issue Oct 18, 2023 · 10 comments

Comments

@jezell
Copy link
Collaborator

jezell commented Oct 18, 2023

If you paste a link directly, it gets linkified. However, if you paste a larger amount of text which contains links in the middle, the links in the text don't get linkified.

@singerdmx
Copy link
Owner

The logic is using regex to recognize the string

@jezell
Copy link
Collaborator Author

jezell commented Oct 18, 2023

@singerdmx yes, but the regex doesn't seem to be applying properly against parts of the text. For example, pasting: "this is a test https://www.google.com" doesn't get linkified, but pasting "https://www.google.com" does

@mboyamike
Copy link

Is there a way to modify the regex that is exposed by the API?

@EchoEllet
Copy link
Collaborator

Is there a way to modify the regex that is exposed by the API?

Hi, I will look into that and if not I will add it as feature

@EchoEllet
Copy link
Collaborator

If you paste a link directly, it gets linkified. However, if you paste a larger amount of text which contains links in the middle, the links in the text don't get linkified.

Issue fixed and I also will provide a way to override the regex

@EchoEllet
Copy link
Collaborator

EchoEllet commented Oct 19, 2023

The logic is using regex to recognize the string

The last PR should fix this issue, closing it to focus on other issues.

@mboyamike
Copy link

Thank you @freshtechtips

@EchoEllet
Copy link
Collaborator

If you paste a link directly, it gets linkified. However, if you paste a larger amount of text which contains links in the middle, the links in the text don't get linkified.

You can try the latest version:

flutter_quill: ^7.4.15

it should be fixed

@EchoEllet
Copy link
Collaborator

EchoEllet commented Oct 20, 2023

If you paste a link directly, it gets linkified. However, if you paste a larger amount of text which contains links in the middle, the links in the text don't get linkified.

Can you close this issue as fixed?

@singerdmx
Copy link
Owner

@freshtechtips I will make you collaborator so you can directly close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants